Removed filtering of empty strings from url paths when importing from postman collection #5868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… postman collection
max-melhuish-depop
requested review from
bijin-bruno,
helloanoop,
lohit-bruno and
naman-bruno
as code owners
| const { protocol = 'http', host, path, port, query, hash } = url || {}; | ||
| const hostStr = Array.isArray(host) ? host.filter(Boolean).join('.') : host || ''; | ||
| const pathStr = Array.isArray(path) ? path.filter(Boolean).join('/') : path || ''; | ||
| const pathStr = Array.isArray(path) ? path.join('/') : path || ''; |
Author
There was a problem hiding this comment.
This is the change basically. This .filter(Boolean) took the array of ["a", "b", ""] to ["a", "b"] before joining
5 tasks
|
|
||
| it('should handle empty variables', async () => { | ||
| const collectionWithEmptyVars = { | ||
| "info": { |
Collaborator
There was a problem hiding this comment.
Is removing the quotes required for the PR, or was it just a linter change?
Author
There was a problem hiding this comment.
I think this is a linter change, I couldn't revert this back to how it was before, kept insisting on this change
Pragadesh44-Bruno
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #5825
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.