Add proxy support for OAuth2 token requests in bruno-requests #5865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
OAuth2 token requests (client_credentials and password grant flows) in bruno-cli were failing when running in environments that require a system proxy. The
bruno-requestspackage was calling axios directly without settinghttpAgent/httpsAgent, causing token fetches to ignore system proxy settings defined viaHTTP_PROXY/HTTPS_PROXYenvironment variables.While bruno-electron and bruno-cli both properly configure proxies for main API requests using
setupProxyAgents, OAuth2 token requests inpackages/bruno-requests/src/auth/oauth2-helper.tsbypassed this mechanism entirely, resulting in failures in CI/CD environments behind corporate proxies.Solution
This PR adds proxy agent support directly to the OAuth2 helper module by:
Adding a
setupProxyAgents()helper function that:HTTP_PROXY/HTTPS_PROXY(and lowercase variants) environment variableshttp-proxy-agentandhttps-proxy-agentmoduleshttpAgent/httpsAgenton the axiosRequestConfigUpdating both OAuth2 grant type functions:
fetchTokenClientCredentials()now callssetupProxyAgents()before making the token requestfetchTokenPassword()now callssetupProxyAgents()before making the token requestAdding comprehensive tests:
Implementation Details
The implementation follows these principles:
packages/bruno-requestssetupProxyAgentsinproxy-util.jsTesting
Usage
Users can now run bruno-cli in proxy environments simply by setting standard environment variables:
OAuth2 token requests will automatically respect these proxy settings, enabling bruno-cli to work in corporate and CI/CD environments that require proxies.
Files Changed
packages/bruno-requests/src/auth/oauth2-helper.ts- Added proxy agent setup logicpackages/bruno-requests/src/auth/oauth2-helper.spec.js- Added tests for proxy configurationFixes the issue where OAuth2 authentication fails in proxy-required environments.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
auth.example.comnode /home/REDACTED/work/bruno/bruno/node_modules/.bin/jest oauth2-helper.spec.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.