WIP: Experimental JSON storage support #444
Draft
+141
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only affects environment files.
Apparently the validator doesn't enforce values get defined as I expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental support for JSON files as an alternative to Bru Lang files. See #407 for more details.
This isn't quite functional yet but I think it's close.
lang: 'bru' | 'json'property. Defaults tobruif not specifiedbruno.jsonfile manuallyI got it mostly working at one point and then somewhere in my cleanup I started going back and forth between the environment file data not being loaded but not throwing an errors and the environment file failing to load while throwing errors.
I've been having a rough time grokking the dispatcher and where relevant processing is actually done. I've gone back and forth pretty frequently between
bruno-electron/src/app/watcher.jsandbruno-electron/src/ipc/collection.jsand I'm either missing something in there or there's something else involved?I'm a TypeScript developer by trade so I'm having additional complications just trying to navigate this codebase without reliable type information. I've added some JSDoc annotations to help but I'm not sure how much more effort I'm willing to invest in this. I'll take another look tomorrow as it's a bit late and being tired doesn't help. 😅