Feature/ntlm auth #3329
Feature/ntlm auth #3329
Conversation
tlaloc911
force-pushed
the
feature/ntlm-auth-2
branch
2 times, most recently
from
2a4eb9c to
07df644
Compare
tlaloc911
force-pushed
the
feature/ntlm-auth-2
branch
from
07df644 to
6a36609
Compare
|
Hi @helloanoop, I created this PR a month ago and now there are conflicts with main branch. If there is any interest in this being merged, just tell me and I'll solve them. |
|
Could you please resolve the conflicts and enable the NTLM authentication ? |
|
Hi, any update? This feature could help a lot of users who cannot use bruno for testing due to lack of NTLM auth support. |
|
I'm wating for Brunos' team feedback @helloanoop , @sreelakshmi-bruno in order to update/solve conflicts. |
|
Hi @tlaloc911, apologies for the delay. Please go ahead and update the PR. We'll get it reviewed by Jan. Thanks! |
Thanks!, I'll update it |
| axiosInstance=NtlmClient(request.ntlmConfig,axiosInstance) | ||
| delete request.ntlmConfig; | ||
| } | ||
|
|
There was a problem hiding this comment.
@tlaloc911 @Pragadesh-45
httpntlm seems to be more mature than axios-ntlm and it also supports workstation param.
IMO, It'll be much cleaner to use httpntlm.ntlm directly to get the Authorization header value rather than let axios-ntlm create the Axios instance for us.
There was a problem hiding this comment.
I'm going through the code on both the libraries and NTLM-Auth seems to be more complicated than I thought.
We also have to check and make sure that the retry(with type3 message) within the interceptor(added by axios-ntlm) will not have any unexpected side effects with other interceptors.
There was a problem hiding this comment.
Also, axios-ntlm is setting new instance of httpAgent and httpsAgents and it will interfere with proxy setup. So, proxy might not work when NTLM Auth is used.
|
@tlaloc911 We have reviewed the changes and it looks good. |
|
I have fixed the conflicts and merged the PR. |
thanks @helloanoop, @ramki-bruno, it is good news!! |
Description
NTLM Auth at request level, collection level and CLI
Resolves #3059
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.