Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: OAuth2: Show details of both token request and user request in the Timeline #2253

Draft
wants to merge 1 commit into
base: fix/oauth2
Choose a base branch
from

Conversation

pietrygamat
Copy link
Contributor

@pietrygamat pietrygamat commented May 6, 2024

Description

This PR builds on top of both #2077 and #2164 . It enhances the timeline to show the details of both OAuth2 token request and user defined request.
This is done because:

When token request is executed, both requests are logged:
Screenshot from 2024-05-06 23-03-43

When using cached credentials (previously obtained access_token), only user request is shown:
Screenshot from 2024-05-06 23-19-15

Also, fixes #1933

@pietrygamat pietrygamat force-pushed the feature/inherit-oauth+basic-auth-client-credentials branch 2 times, most recently from 0c1e1ab to edd0088 Compare May 7, 2024 18:03
@pietrygamat pietrygamat force-pushed the feature/inherit-oauth+basic-auth-client-credentials branch from edd0088 to b0e11a4 Compare June 2, 2024 16:09
@pietrygamat pietrygamat force-pushed the feature/inherit-oauth+basic-auth-client-credentials branch 3 times, most recently from fd04368 to 1ec9f28 Compare June 21, 2024 22:28
@pietrygamat pietrygamat force-pushed the feature/inherit-oauth+basic-auth-client-credentials branch 2 times, most recently from c649462 to d2c2b52 Compare July 26, 2024 18:14
@pietrygamat pietrygamat force-pushed the feature/inherit-oauth+basic-auth-client-credentials branch from d2c2b52 to 2298d90 Compare August 22, 2024 22:55
@pietrygamat pietrygamat force-pushed the feature/inherit-oauth+basic-auth-client-credentials branch from 2298d90 to 77b8a0c Compare August 28, 2024 00:04
@pietrygamat pietrygamat force-pushed the feature/inherit-oauth+basic-auth-client-credentials branch 3 times, most recently from 26045ef to e8e5da1 Compare September 23, 2024 22:15
@leikoilja
Copy link

this is really needed

@pietrygamat pietrygamat force-pushed the feature/inherit-oauth+basic-auth-client-credentials branch from e8e5da1 to 2f6c026 Compare January 11, 2025 18:53
@pietrygamat pietrygamat changed the base branch from main to fix/oauth2 January 11, 2025 18:53
@helloanoop helloanoop assigned lohit-bruno and unassigned lohxt1 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oauth2.0 - client Credentials -> Get Access Token =>not good URL?
4 participants