Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: visualize better when a row is disabled #1475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

banjo
Copy link
Contributor

@banjo banjo commented Jan 29, 2024

Description

The checkbox currently has no visual indication whenever it is pressed, this PR adds a slightly lower opacity and light gray background color to the row to make it clear that it is disabled.

CleanShot 2024-01-29 at 22 37 53

This applies to all places where it can be disabled (I think).

Also, my IDE automatically sorted the imports 🫣

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@banjo banjo force-pushed the feature/disabled-rows branch from 9e7f5ab to cc623ac Compare January 30, 2024 08:16
@martinsefcik
Copy link
Contributor

@banjo Question is if delete button opacity should be also changed as this button is doing the same action and it does not matter if row is enabled or disable. Also checkbox opacity is also questionable. It looks a bit to me as these two action components are also disabled but they are not. What about changing "opacity" for whole row but not for these two components ? But I guess It's need to be done differently using background, text styling and not using opacity because these two components are children of row.

@helloanoop helloanoop self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants