Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1352): add collection headers to introspection query #1353

Conversation

reggermont
Copy link
Contributor

@reggermont reggermont commented Jan 9, 2024

Description

Resolve #1352 by adding collection headers to the introspection query.

Considering a graphql api requiring mandatory headers defined in the collection headers, the introspection would currently fail.

For the same API:

Before:
image

After:
image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@reggermont reggermont force-pushed the feature/add-collection-headers-to-introspection-query branch from ff059f2 to 65f2858 Compare January 9, 2024 17:50
@reggermont reggermont force-pushed the feature/add-collection-headers-to-introspection-query branch from 65f2858 to a15ccef Compare January 9, 2024 17:52
@helloanoop helloanoop merged commit 969c440 into usebruno:main Jan 29, 2024
2 of 3 checks passed
@helloanoop
Copy link
Contributor

Thanks for fixing this @reggermont !

This was a simple fix. My apologies for merging this late.

@reggermont
Copy link
Contributor Author

My pleasure!

You have your life, don't be sorry 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Fetch collection headers for introspection
2 participants