Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(#1093) Added ability to open tab context menu #1105

Closed

Conversation

StonyTV
Copy link
Contributor

@StonyTV StonyTV commented Nov 30, 2023

Hello,

I am submitting this PR to initiate context menus for the tabs.

Description

As of today, I have added two simple features: New Request and Tab Clone.

image

It took me some time to find the right approach and process. In my opinion, it is quite comprehensible, relies on the state of the tabs, and respects the "separation of concerns" principle, particularly in event management.

If this PR is accepted, a significant milestone, which I believe is highly expected, will be managing tab closures (individually, all except the current one, etc.). The challenge will lie in controlling the "draft mode" with control modals.

Please let me know your feedback if you think of a different approach.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Issue : #1093

@StonyTV StonyTV changed the title Feat(#1099) Added ability to open tab context menu Feat(#1093) Added ability to open tab context menu Nov 30, 2023
@binaryfire
Copy link

Thanks for working on this. Could you add "Close all" and "Close all to the right"? Currently there's no easy way to close all open tabs.

@StonyTV
Copy link
Contributor Author

StonyTV commented Feb 14, 2024

Hello @helloanoop. For information, I updated the branch and carried out the tests. The feature still works properly and is still ready to merge. Once merged, it would add many features to this tab context menu.

@Phyziik
Copy link

Phyziik commented Mar 31, 2024

Closes: #715
Sorry, I'm trying to link this to the Feature request issue (I'm new to contributin). I was about to work on this in another branch, but then I double checked and found yours. If there is work remaining after the merge, I'll make another PR.

@helloanoop
Copy link
Contributor

Closing this PR as the Tab Context Menu was implemented in #2183

@helloanoop helloanoop closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants