fix(#1419): fixed ignored SSL verification and client certificates co…

…nfiguration when using SOCKS proxy (#1420)
usebruno · Jan 29, 2024 · a077d65 · a077d65
1 parent c3f6318
commit a077d65
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/bruno-cli/src/runner/run-single-request.js b/packages/bruno-cli/src/runner/run-single-request.js
@@ -158,9 +158,11 @@ const runSingleRequest = async function (
       }
 
       if (socksEnabled) {
-        const socksProxyAgent = new SocksProxyAgent(proxyUri);
-        request.httpsAgent = socksProxyAgent;
-        request.httpAgent = socksProxyAgent;
+        request.httpsAgent = new SocksProxyAgent(
+          proxyUri,
+          Object.keys(httpsAgentRequestFields).length > 0 ? { ...httpsAgentRequestFields } : undefined
+        );
+        request.httpAgent = new SocksProxyAgent(proxyUri);
       } else {
         request.httpsAgent = new PatchedHttpsProxyAgent(
           proxyUri,

diff --git a/packages/bruno-electron/src/ipc/network/index.js b/packages/bruno-electron/src/ipc/network/index.js
@@ -169,9 +169,11 @@ const configureRequest = async (
     }
 
     if (socksEnabled) {
-      const socksProxyAgent = new SocksProxyAgent(proxyUri);
-      request.httpsAgent = socksProxyAgent;
-      request.httpAgent = socksProxyAgent;
+      request.httpsAgent = new SocksProxyAgent(
+        proxyUri,
+        Object.keys(httpsAgentRequestFields).length > 0 ? { ...httpsAgentRequestFields } : undefined
+      );
+      request.httpAgent = new SocksProxyAgent(proxyUri);
     } else {
       request.httpsAgent = new PatchedHttpsProxyAgent(
         proxyUri,