Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert changes for bias & scale #51

Closed
wants to merge 1 commit into from
Closed

fix: revert changes for bias & scale #51

wants to merge 1 commit into from

Conversation

beersandrew
Copy link
Contributor

  • fixes were made recently to appease usdchecker with respect to warnings about bias and scale, however these values are intentional for this asset, reverting them to how they were

eefd571#r124902221

- fixes were made recently to appease usdchecker with respect to warnings about bias and scale, however these values are intentional for this asset, reverting them to how they were
beersandrew referenced this pull request Aug 21, 2023
updating warnings for bias and scale based on usdchecker recommendations
@erich666
Copy link
Contributor

erich666 commented Aug 22, 2023

Thanks, fast work! I'm in the process of revising this test model's lighting and other characteristics based on the feedback and PR from @pablode #44 feedback

It will have this fix and the Dome Light orientation fix, as well as the inputs:intensity problem mentioned there. So, please hold off on approving these two PRs, to help me avoid merge headaches. Mine should work a bit better, I hope.

I would submit my PR today, but am having problems myself with running usdchecker on a new PC. Hopefully I'll have that sorted in a day or so.

@beersandrew
Copy link
Contributor Author

Thanks, fast work! I'm in the process of revising this test model's lighting and other characteristics based on the feedback and PR from @pablode #44 feedback

It will have this fix and the Dome Light orientation fix, as well as the inputs:intensity problem mentioned there. So, please hold off on approving these two PRs, to help me avoid merge headaches. Mine should work a bit better, I hope.

I would submit my PR today, but am having problems myself with running usdchecker on a new PC. Hopefully I'll have that sorted in a day or so.

sounds good!

@erich666
Copy link
Contributor

I've restored the bias and scale values in this PR, along with other issues discussed in #44

So, I think this PR can be closed (and not used), as the new PR also fixes them.

@jcowles
Copy link
Collaborator

jcowles commented Sep 2, 2023

Closing per #51 (comment)
Thanks all!

@jcowles jcowles closed this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants