Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputs:in.connect has wrong type in test_assets\TextureTransformTest #87

Open
syoyo opened this issue May 9, 2024 · 0 comments
Open

Comments

@syoyo
Copy link

syoyo commented May 9, 2024

In test_assets\TextureTransformTest
inputs:in.connect uses token type,

token inputs:in.connect = </TextureTransformTest/Materials/Offset_U_53148/uvReader.outputs:result>

where float2 is expected according to the spec
https://openusd.org/release/spec_usdpreviewsurface.html#transform2d

            def Shader "usdTransform"
            {
                uniform token info:id = "UsdTransform2d"
                token inputs:in.connect = </TextureTransformTest/Materials/Offset_V_53152/uvReader.outputs:result>
                ^^^^^^^^^^^^^^^^^^^^^^^
                float inputs:rotation = 0
                float2 inputs:scale = (1, 1)
                float2 inputs:translation = (0, -0.5)
                float2 outputs:result
            }

Surprisingly, OpenUSD does not check the type of Attribute when it is a Attribute Connection, so tools using OpenUSD can open it without errors(e.g. Blender 4.1)

image
(Blender 4.1)

Anyway, using float2 inputs:in.connect would be better to make this USD test scene conformant to UsdPreviewSurface Spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant