Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse test failures in usd-wg/assets #135

Open
syoyo opened this issue Apr 6, 2024 · 4 comments
Open

Parse test failures in usd-wg/assets #135

syoyo opened this issue Apr 6, 2024 · 4 comments
Labels
bug Something isn't working question Further information is requested

Comments

@syoyo
Copy link
Collaborator

syoyo commented Apr 6, 2024

Branch: dev
Procedure:

$ cd <tinyusdz>/build
$ python ../tests/parse_usd/runner.py </path/to/usd-wg/assets>
# (run `test_tinyusdz` command for each USD files in the specified folder)

Failure cases

/home/syoyo/work/usd/assets/full_assets/Teapot/Teapot_Materials.usd Failed
/home/syoyo/work/usd/assets/test_assets/TextureTransformTest/TextureTransformTest.usd Failed
/home/syoyo/work/usd/assets/test_assets/AlphaBlendModeTest/AlphaBlendModeTest.usd Failed
/home/syoyo/work/usd/assets/full_assets/StandardShaderBall/layers/environment.usda Failed
/home/syoyo/work/usd/assets/full_assets/StandardShaderBall/layers/shaderball.usda Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd_10cm.usda Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd.usda Failed
/home/syoyo/work/usd/assets/test_assets/schemaTests/usdGeom/meshes/normals_types/normalsTypes.usda Failed
/home/syoyo/work/usd/assets/test_assets/schemaTests/usdGeom/meshes/points_types/pointsTypes.usda Failed
/home/syoyo/work/usd/assets/test_assets/RelationshipEncapsulationTests/InternalReferenceTest.usda Failed
/home/syoyo/work/usd/assets/full_assets/ElephantWithMonochord/SoC-ElephantWithMonochord.usdc Failed
/home/syoyo/work/usd/assets/full_assets/UsdCookie/UsdCookie.usdz Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd.usdz Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd_10cm.usdz Failed
@syoyo
Copy link
Collaborator Author

syoyo commented Apr 6, 2024

Reason of failures

Checked = fixed

  • Nested variantSet Teapot/Teapot_Materials.usd Nested VariantSet #94
  • ReconstructMaterialBindingProperties():2168 PURPOSE must not have nested namespaces for 'mateirial:binding' StandardShaderBall/layers/environment.usda
  • Comment in Stage meta McUsd/McUsd_10cm.usda Parse failure for comment in CustomLayerData #138
  • type mismatch: Parsing attribute normals failed. Error: Property type mismatch. normals expects type normal3f[] but defined as type point3f[] normals_types/normalsTypes.usda
    • Expected failure?
  • Value block + metadata RelationshipEncapsulationTests/InternalReferenceTest.usda Parse failure for a relationship with ValueBlock and metadata #137
  • type mismatch: 0 Parsing attribute inputs:st failed. Error: Internal error. Invalid attribute value? get_value failed. in ElephantWithMonochord/SoC-ElephantWithMonochord.usdc fixed via 8a5491d
  • LoadUSDZFromMemory():545 Asset no[1] Image width too large UsdCookie/UsdCookie.usdz
  • doubleSided attribute in Mesh is not qualified with uniform. bool doubleSided = 1 in McUsd/McUsd_10cm.usda McUsd/McUsd_10cm.usdz

@syoyo syoyo added bug Something isn't working question Further information is requested labels Apr 6, 2024
@syoyo
Copy link
Collaborator Author

syoyo commented Apr 6, 2024

After fixing some issues in TinyUSDZ parser, now failure cases are reduced to

/home/syoyo/work/usd/assets/full_assets/Teapot/Teapot_Materials.usd Failed
/home/syoyo/work/usd/assets/full_assets/StandardShaderBall/layers/shaderball.usda Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd_10cm.usda Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd.usda Failed
/home/syoyo/work/usd/assets/test_assets/schemaTests/usdGeom/meshes/normals_types/normalsTypes.usda Failed
/home/syoyo/work/usd/assets/test_assets/schemaTests/usdGeom/meshes/points_types/pointsTypes.usda Failed
/home/syoyo/work/usd/assets/test_assets/RelationshipEncapsulationTests/InternalReferenceTest.usda Failed
/home/syoyo/work/usd/assets/full_assets/ElephantWithMonochord/SoC-ElephantWithMonochord.usdc Failed
/home/syoyo/work/usd/assets/full_assets/UsdCookie/UsdCookie.usdz Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd.usdz Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd_10cm.usdz Failed

@syoyo
Copy link
Collaborator Author

syoyo commented Apr 17, 2024

Failure cases with dev branch

/home/syoyo/work/usd/assets/full_assets/Teapot/Teapot_Materials.usd Failed
/home/syoyo/work/usd/assets/test_assets/TextureTransformTest/TextureTransformTest.usd Failed
/home/syoyo/work/usd/assets/full_assets/StandardShaderBall/layers/shaderball.usda Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd_10cm.usda Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd.usda Failed
/home/syoyo/work/usd/assets/test_assets/schemaTests/usdGeom/meshes/normals_types/normalsTypes.usda Failed
/home/syoyo/work/usd/assets/test_assets/schemaTests/usdGeom/meshes/points_types/pointsTypes.usda Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd.usdz Failed
/home/syoyo/work/usd/assets/full_assets/McUsd/McUsd_10cm.usdz Failed

@lighttransport lighttransport deleted a comment from tellypresence Apr 24, 2024
@hybridherbst
Copy link

Good test list and documentation!
cc @beersandrew, you might be interested in this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants