Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data transfer function and uncertainty #14

Merged
merged 6 commits into from
Jan 31, 2020

Conversation

iej2106
Copy link
Contributor

@iej2106 iej2106 commented Jan 24, 2020

Obtaining Transfer function T(k) data + uncertanty

  1. Loading lya: k, Pk to data object -> P(k)nCDM
  2. Loading P(k)cdm (from class) for corresponding k in lya data.
  3. Calculate uncertanty in T(k) from data uncertanty in lya data
  4. Return data: k, T(k), T(k)_unc

@timothydmorton
Copy link
Collaborator

@iej2106 if you accept the invitation to the usc-cosmolab organization, I can officially assign you to #5

Copy link
Collaborator

@timothydmorton timothydmorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments; if you push edits to the same branch from which you made the PR, it will update.

lya/data.py Outdated Show resolved Hide resolved
lya/data.py Outdated Show resolved Hide resolved
lya/data.py Outdated Show resolved Hide resolved
@timothydmorton timothydmorton changed the title v1 data transfer function and uncertainty Jan 29, 2020
@jlashner jlashner mentioned this pull request Jan 30, 2020
Copy link
Collaborator

@timothydmorton timothydmorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great- only thing I would suggest is that it's more standard practice to comment above the code that's about to come rather than below. Switch that up and then I'll merge this in.

@timothydmorton timothydmorton merged commit 424318f into usc-cosmolab:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants