Wrote objective and residuals functions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RemingtonGerras (and whomever you were working with)- accept the invitation for the usc-cosmolab group and I can officially assign you those issues. |
timothydmorton
requested changes
Jan 29, 2020
lya/analysis.py
Outdated
|
|
||
| def objective(pars, data): | ||
| """Objective function to miminize | ||
| """ | ||
|
|
||
|
|
||
| return ((residuals(*pars, data)**2 / data.uncertainty**2).sum() |
There was a problem hiding this comment.
the Data object doesn't have an attribute called .uncertainty; it's called .y_unc
There was a problem hiding this comment.
The current implementation of the data object has data.k, data.P_k, and data.P_k_unc attributes. Should we update the attributes here accordingly?
lya/analysis.py
Outdated
| @@ -22,11 +22,13 @@ def residuals(pars, data): | |||
| Data to be compared with model. | |||
| """ | |||
|
|
|||
| return data.y - model(k, *pars) | |||
lya/.#analysis.py
Outdated
| @@ -0,0 +1 @@ | |||
| [email protected]:1580152665 | |||
There was a problem hiding this comment.
please delete this file from the repo with git rm lya/.#analysis.py --cached
|
@RemingtonGerras do you want to finish up this PR before the meeting today? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Believe Christian and I have written the residual and objective functions. Untested, however...