Merge pull request #61 from us-irs/finished-params-tweak

finished params tweak
us-irs · Nov 8, 2023 · c22c3e0 · c22c3e0
2 parents 95762af + 7b6788e
commit c22c3e0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Changed
 
+- Reordered argument order for `FinishedParams` to be in line with the CFDP standard. This might
+  break code not using keyword arguments.
 - Renamed `FileDeliveryStatus` to `FileStatus` to be closer to the CFDP name.
 - Moved `spacepackets.cfdp.pdu.finished.FileDeliveryStatus` to `spacepackets.cfdp.defs.FileStatus`.
   The new enumeration is also re-exported in `spacepackets.cfdp`.

diff --git a/spacepackets/cfdp/pdu/__init__.py b/spacepackets/cfdp/pdu/__init__.py
@@ -7,7 +7,7 @@
 
 from .ack import AckPdu, TransactionStatus
 from .eof import EofPdu
-from .file_data import FileDataPdu
+from .file_data import FileDataPdu, FileDataParams
 from .file_directive import (
     AbstractFileDirectiveBase,
     DirectiveType,

diff --git a/spacepackets/cfdp/pdu/finished.py b/spacepackets/cfdp/pdu/finished.py
@@ -27,9 +27,9 @@
 
 @dataclass
 class FinishedParams:
+    condition_code: ConditionCode
     delivery_code: DeliveryCode
     file_status: FileStatus
-    condition_code: ConditionCode
     file_store_responses: List[FileStoreResponseTlv] = field(default_factory=lambda: [])
     fault_location: Optional[EntityIdTlv] = None