Fix/hvt drop seccomp v2 - #974
Open
pocopepe wants to merge 2 commits into
Open
Conversation
Ref: urunc-dev#648 Signed-off-by: viju <avijusanjai@gmail.com>
Ref: urunc-dev#648 Signed-off-by: viju <avijusanjai@gmail.com>
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
solo5-hvt applies its own seccomp filter since v0.11.0, so urunc applying one on top stacks the two and the tender gets SIGSYS'd before the guest boots. This drops the go side filter and lets solo5-hvt handle it.
Also bumps solo5 to v0.12.1 in CI, the urunc-deploy image and the docs, since anything below v0.11.0 has no filter of its own and would leave hvt unconfined. v0.12.1 also carries the ring buffer alignment fix from Solo5/solo5#660, which the networked rumprun guests on hvt need to boot at all.
Dropped the Hvt-rumprun-without-seccomp case, it can't pass anymore now that solo5-hvt always applies a filter. docs/design/seccomp.md updated to match.
One thing, this shouldn't merge before urunc-dev/monitors-build#5. docs/installation.md hardcodes a monitors-build tag that still ships solo5 v0.9.3, so until that's out anyone following the prebuilt path ends up with no seccomp at all. I'll push the tag update here once the release is cut.
Related issues
How was this tested?
All four e2e suites against solo5 v0.12.1 and hyperlight v0.12.1, all passing:
make test_ctr(18),make test_nerdctl(25),make test_crictl(13),make test_docker(15).LLM usage
Claude Opus 5 helped me finding out every reference of solo5, and help clean up my description.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).