test(unikernels): Add unit test suite for Unikraft driver - #945
Open
safiya2610 wants to merge 1 commit into
Open
test(unikernels): Add unit test suite for Unikraft driver#945safiya2610 wants to merge 1 commit into
safiya2610 wants to merge 1 commit into
Conversation
Signed-off-by: safiya2610 <lci2023053@iiitl.ac.in>
✅ Deploy Preview for urunc canceled.
|
Author
Author
|
@cmainas Can you please review the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
The Unikraft unikernel driver in
pkg/unikontainers/unikernels/unikraft.gocurrently lacks unit test coverage. Critical logic such as command-line parameter generation, version-based network configuration, and root filesystem handling is not protected against regressions.Summary
This PR introduces a comprehensive table-driven unit test suite (
unikraft_test.go) for the Unikraft driver.Changes include:
TestUnikraftCommandString: Verifies CLI parameter generation for standard executions, environment variables, network arguments, and VFS configurations (initrd).TestUnikraftSupportsFS&TestUnikraftSupportsBlock: Validates that Unikraft correctly reports support only for9pfsand rejectsext2,virtiofs, and block devices.TestUnikraftInitVersionHandling: Verifies the version comparison logic inconfigureUnikraftArgs(), ensuring legacy networking arguments (netdev.ipv4_addr) are applied for Unikraft< 0.16.1, and modern arguments (netdev.ip) for>= 0.16.1.Testing
go test -v ./pkg/unikontainers/unikernels/...(AllUnikrafttests pass).go builddoes not break.Linked Issues
Fixes: #943