Skip to content

Commit

Permalink
chore: create CODEOWNERS (privacy-scaling-explorations#301)
Browse files Browse the repository at this point in the history
* chore: create CODEOWNERS

* docs: update CONTRIBUTING.md
  • Loading branch information
cedoor authored Jun 19, 2024
1 parent bcbc6ce commit e1d587e
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
16 changes: 16 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# These owners will be the default owners for everything in the repo.
# They will be added as reviewers for PR related to configuration files.
* @cedoor @sripwoud

# When someone opens a pull request that only modifies specific packages,
# only the following users and not the default owners defined above will be
# requested for a review.
/packages/baby-jubjub/ @cedoor @artwyman
/packages/eddsa-poseidon/ @cedoor @artwyman
/packages/imt/ @cedoor
/packages/lazytower/ @LCamel
/packages/lean-imt/ @cedoor @vplasencia
/packages/poseidon-cipher/ @ctrlc03
/packages/poseidon-proof/ @cedoor @vplasencia @0xjei
/packages/imt/ @cedoor
/packages/utils/ @cedoor @artwyman
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ Pull requests are great if you want to add a feature or fix a bug. Here's a quic

7. Push to your fork and submit a pull request on our `main` branch. Please provide us with some explanation of why you made the changes you made. For new features make sure to explain a standard use case to us.

> [!NOTE]
> When a new package is created or a new feature is added to the repository, the contributor will be added to the `.github/CODEOWNERS` file to review and approve any future changes to their code.
## CI (Github Actions) Tests

We use GitHub Actions to test each PR before it is merged.
Expand All @@ -46,7 +49,7 @@ We always use ESLint and Prettier. To check that your code follows the rules, si

For commits it is recommended to use [Conventional Commits](https://www.conventionalcommits.org).

Don't worry if it looks complicated, in our repositories, `git commit` opens an interactive app to create your conventional commit.
Don't worry if it looks complicated. In our repositories, `git commit` opens an interactive app to create your conventional commit.

Each commit message consists of a **header**, a **body** and a **footer**. The **header** has a special format that includes a **type**, a **scope** and a **subject**:

Expand Down

0 comments on commit e1d587e

Please sign in to comment.