Include flag descriptions when using zsh completion #1903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR ensures that flags'
Usage
fields are included when using zsh completion (if their description is non-empty). This functionality is in line with how this is handled for command completion, seecli/help.go
Line 163 in 043b774
Without Changes
With changes
Testing
I tested these changes locally against a CLI tool that I am migrating to urfave/cli/v3. I also ran
make test
and encountered no errors, but then again I also did not add any test cases (would be open to doing so if this feature is desired).Release Notes