Cleanup: Remove unnecessary intermediate variables

[1ambd4]

What type of PR is this?

• cleanup

What this PR does / why we need it:

In the initial version of the code, Commands is of type []Command.

cli/app.go

Line 25 in aced6e8

Commands []Command

In this case iterating over Commands using range will generate intermediate variables, so it needs to be written as follows

cli/app.go

Lines 90 to 95 in aced6e8

	newCmds := []Command{}
	for _, c := range a.Commands {
	c.HelpName = fmt.Sprintf("%s %s", a.HelpName, c.Name)
	newCmds = append(newCmds, c)
	}
	a.Commands = newCmds

But this part of the code has changed in the last decade. Now, Commands is of type []*Command and, in my opinion, there is no need to manipulate intermediate variables.

cli/app.go

Line 54 in 7656c5f

Commands []*Command

cli/app.go

Lines 232 to 244 in 7656c5f

	var newCommands []*Command
	for _, c := range a.Commands {
	cname := c.Name
	if c.HelpName != "" {
	cname = c.HelpName
	}
	c.separator = a.separator
	c.HelpName = fmt.Sprintf("%s %s", a.HelpName, cname)
	c.flagCategories = newFlagCategoriesFromFlags(c.Flags)
	newCommands = append(newCommands, c)
	}
	a.Commands = newCommands

The same reason is true for the removal of code in cli/command.go.

cli/command.go

Line 34 in aced6e8

Subcommands []Command

cli/command.go

Lines 197 to 202 in aced6e8

	var newCmds []Command
	for _, cc := range app.Commands {
	cc.commandNamePath = []string{c.Name, cc.Name}
	newCmds = append(newCmds, cc)
	}
	app.Commands = newCmds

cli/command.go

Line 42 in 7656c5f

Subcommands []*Command

cli/command.go

Lines 135 to 143 in 7656c5f

	var newCmds []*Command
	for _, scmd := range c.Subcommands {
	if scmd.HelpName == "" {
	scmd.HelpName = fmt.Sprintf("%s %s", c.HelpName, scmd.Name)
	}
	scmd.separator = c.separator
	newCmds = append(newCmds, scmd)
	}
	c.Subcommands = newCmds

Special notes for your reviewer:

I'm not familiar with the Go language, so please point out any errors in my understanding, and thanks for reviewing.

Release Notes

NONE

[dearchap]

Thank you @1ambd4