Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:(issue_1695) Change tests to use assert and require #1853

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

dearchap
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • cleanup

What this PR does / why we need it:

(REQUIRED)

Use assert and require in all tests to simplify test checks

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1695

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

make

Release Notes

(REQUIRED)


Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@dearchap dearchap merged commit eeebafc into urfave:main Dec 27, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testify, and update tests to use it rather than expect
2 participants