shorten Empty and NotEmpty

urfave · Aug 22, 2024 · 7bf0162 · 7bf0162
1 parent 241e0c6
commit 7bf0162
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/internal/testing/testing.go b/internal/testing/testing.go
@@ -283,23 +283,21 @@ func RequireFalse(t *testing.T, value bool, msgAndArgs ...interface{}) {
 }
 
 func Empty(t *testing.T, object interface{}, msgAndArgs ...interface{}) bool {
-	pass := isEmpty(object)
-	if !pass {
+	if !isEmpty(object) {
 		t.Helper()
 		return fail(t, fmt.Sprintf("Should be empty, but was %v", object), msgAndArgs...)
 	}
 
-	return pass
+	return true
 }
 
 func NotEmpty(t *testing.T, object interface{}, msgAndArgs ...interface{}) bool {
-	pass := !isEmpty(object)
-	if !pass {
+	if isEmpty(object) {
 		t.Helper()
 		return fail(t, fmt.Sprintf("Should NOT be empty, but was %v", object), msgAndArgs...)
 	}
 
-	return pass
+	return true
 }
 
 func Nil(t *testing.T, object interface{}, msgAndArgs ...interface{}) bool {