Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noun: properly type tree addressing functions #4

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

Fang-
Copy link
Member

@Fang- Fang- commented Mar 6, 2025

The fragmenter() should produce a function that takes and produces a Noun. The at() functions should produce a Noun, because they call a function produced by the fragmenter().

(Having .at() on Atoms is a little bit weird, but lets you call it on opaque Nouns. It'll crash in the same way that it would crash on shallow Cells or other "miss" cases.)

Verified

This commit was signed with the committer’s verified signature.
Fang- fang
The fragmenter() should produce a function that takes and produces a
Noun. The at() functions should produce a Noun, because they call a
function produced by the fragmenter().

(Having .at() on Atoms is a little bit weird, but lets you call it on
opaque Nouns. It'll crash in the same way that it would crash on shallow
Cells or other "miss" cases.)
@Fang- Fang- requested a review from arthyn March 6, 2025 20:24
Copy link
Contributor

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fang- Fang- merged commit e4a6952 into master Mar 7, 2025
@Fang- Fang- deleted the m/typed-fragmenter branch March 7, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants