Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for base library v4 #56

Merged
merged 47 commits into from
Jun 25, 2024
Merged

Update for base library v4 #56

merged 47 commits into from
Jun 25, 2024

Conversation

RoussKS
Copy link

@RoussKS RoussKS commented May 20, 2024 •
edited
Loading

  • Increase upmind/provision-provider-base version requirement to ^4.0 and PHP versions 8.1, 8.2, 8.3
  • Removed debug flags
  • Introduce PHPStan with level 4 strictness
  • Introduce GIthub actions for static analysis
  • Introduce local development dockerfiles & Makefile to quickly setup
  • Update PHP-CS-Fixer to latest version that supports PHP 8.3
  • Added php required extensions to composer
  • Commented out redundant code, with ToDo: to be removed after checking, commit: 3fde8cd
  • Removed code that was never reached as return statements were earlier, commit: b11dc23

Roussetos Karafyllakis added 30 commits May 9, 2024 18:01
Deleted .idea folder
d44d173
Updated gitignore
ea5a64c
Introduce docker file for local development
04451c0
introduce Makefile & update composer version requirements
7f1c5f5
Update PHP-CS-Fixer version for PHP 8
d90c644
composer require --dev phpstan/phpstan
38e9277
Introduce static analysis github workflow
44fa79e
removed configuration debug property & references from providers as d…
f4fc0f5 
…eprecated
Updated Data parameters docblocks for params to match method params d…
939b949 
…eclaration
Updated Demo Provider, increase entropy for uniqid function
a331cb8
Update DirectAdmin docblocks and simplify conditionals. throw instead…
7ff333a 
… of return throw were applicable
merge conditions for exception handling
0f03143
Update error message to handle null values in a cleaner manner
e8c7003
update directory and app names to use unique identifier
b99d319
use custom, unique service name for local development docker containe…
23a8289 
…r to prevent conflicts
remove debug flag from WHM V1 dataset
8bdbf31
Update final docblock throws for DirectAdmin provider
438503c
removed not used imports
2713041
added throw tags docblocks for enhance and resolve staticc analysis p…
47eb789 
…oints
Admin Provider static analysis
f7d73e9
added no-return to exception method and remove 4th not required param…
e5c1ff5 
… (methdo requires 3)
status resultset is a string, but because of loading a class, static …
7259a85 
…analysis was complaining
static analysis fixes on enhance provider, non-strict comparison betw…
2687b64 
…een class and text, as the return item from the API is the strong of the status or the app type
set result of method in docblock to prevent complaints by static anal…
52318f0 
…ysis
Update example provider
801e19b
Interworx API requires SOAP extension and also never returns null whe…
e0d5cac 
…n parsing a response but an array
Update Interworx code to resolve static analysis issues and add relev…
122ea76 
…ant @throws
install php-soap extension to the container
59fbb0c
self throw exception instead of static
9c80fd3
dded throw tags in docblocks
46b4619
@RoussKS RoussKS requested a review from uphlewis May 20, 2024 13:33
@RoussKS RoussKS self-assigned this May 20, 2024
@uphlewis uphlewis merged commit 4e22ff1 into main Jun 25, 2024
3 checks passed
@uphlewis uphlewis deleted the TR-77-update-for-compatibility-with-base-library-v4 branch June 25, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uphlewis uphlewis Awaiting requested review from uphlewis

Assignees

@RoussKS RoussKS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoussKS @uphlewis