Update Namecheap use Util for determining if locking is enabled - add…

… de to disabled list
upmind · Jun 14, 2023 · 09d61fd · 09d61fd
1 parent fc5902b
commit 09d61fd
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/src/Helper/Utils.php b/src/Helper/Utils.php
@@ -129,6 +129,19 @@ public static function lookupNameservers(string $domain, bool $orFail = true): ?
         }
     }
 
+    /**
+     * Determine whether  the registry of the given TLD supports domain locking.
+     */
+    public static function tldSupportsLocking(string $tld): bool
+    {
+        $unsupported = [
+            'io',
+            'de',
+        ];
+
+        return !in_array(static::getRootTld($tld), $unsupported);
+    }
+
     /**
      * Determine whether the registry of the given TLD supports explicit renewal.
      */

diff --git a/src/Namecheap/Helper/NamecheapApi.php b/src/Namecheap/Helper/NamecheapApi.php
@@ -32,10 +32,6 @@ class NamecheapApi
      */
     protected const ALLOWED_CONTACT_TYPES = ['registrant', 'tech', 'admin', 'auxbilling'];
 
-    public const NO_LOCK_TLDS = [
-        'io',
-    ];
-
     /**
      * Contact Types
      */
@@ -311,9 +307,7 @@ public function getRegistrarLockStatus(string $domainName): bool
             'DomainName' => $domainName,
         ];
 
-        $tld = Utils::getTld($domainName);
-
-        if (in_array($tld, self::NO_LOCK_TLDS)) {
+        if (!Utils::tldSupportsLocking(Utils::getTld($domainName))) {
             return false;
         }
 

diff --git a/src/Namecheap/Provider.php b/src/Namecheap/Provider.php
@@ -382,11 +382,8 @@ public function setLock(LockParams $params): DomainResult
         $lock = !!$params->lock;
 
         try {
-            if (in_array($params->tld, NamecheapApi::NO_LOCK_TLDS)) {
-                throw $this->errorResult(
-                    sprintf('Domain %s does not support to change Registrar Lock.', $domainName),
-                    $params
-                );
+            if (!Utils::tldSupportsLocking($params->tld)) {
+                throw $this->errorResult(sprintf('%s domains do not support locking', $params->tld));
             }
 
             $currentLockStatus = $this->api()->getRegistrarLockStatus($domainName);