Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#58 - Registry docblocks collection return types #60

Merged
merged 11 commits into from
Apr 16, 2024
Merged

#58 - Registry docblocks collection return types #60

merged 11 commits into from
Apr 16, 2024

Conversation

RoussKS
Copy link

@RoussKS RoussKS commented Mar 15, 2024 •
edited
Loading

Closes #58

  • Increase phpstan to level 2
  • Resolved collection return type docblocks
  • Resolved quite a few docblock issues that phpstan flagged on level 2
  • Extra attention to changing the arguments sorting order (required before optional, as per phpstan), however, the fix change should be enough e6712ab

@RoussKS RoussKS requested review from uphlewis and adamquaile March 15, 2024 17:23
@RoussKS RoussKS linked an issue Mar 15, 2024 that may be closed by this pull request
Update Registry docblocks - fix generic templates for collection items #58
Closed
@RoussKS RoussKS removed the request for review from adamquaile April 2, 2024 19:38
This was referenced Apr 2, 2024
Merged
Merged
@RoussKS RoussKS self-assigned this Apr 2, 2024
uphlewis
uphlewis requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@uphlewis uphlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks - lets just discuss the int/float cast in FormFactory

Roussetos Karafyllakis added 4 commits April 7, 2024 19:55
@RoussKS RoussKS requested a review from uphlewis April 16, 2024 15:34
@uphlewis uphlewis merged commit 21324fb into v5-dev Apr 16, 2024
6 checks passed
@uphlewis uphlewis deleted the 58-registry-docblocks-collection-return-types branch April 16, 2024 16:37
@RoussKS RoussKS mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uphlewis uphlewis Awaiting requested review from uphlewis

Assignees

@RoussKS RoussKS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Registry docblocks - fix generic templates for collection items
2 participants
@RoussKS @uphlewis