🐢 ユーザ削除機能 #183
Open
🐢 ユーザ削除機能 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1tikurisu
reviewed
Sep 4, 2022
There was a problem hiding this comment.
全体的に、前回プルリク(#182)の変更を取り消すような差分がいっぱい入ってるんやけど、なんでやろ
いっかいmain取り込んで、mainを優先するようにコンフリクト解消してほしい！
Comment on lines
+21
to
+38
|
|
||
| try { | ||
| await deleteDoc(usersRef) | ||
| } catch (e) { | ||
| console.error(e) | ||
| } | ||
|
|
||
| try { | ||
| travelinkDocs.forEach(async (travelinkDoc) => { | ||
| const travelinkRef = doc( | ||
| collection(db, 'travelinks'), | ||
| travelinkDoc.data().id | ||
| ) | ||
| await deleteDoc(travelinkRef) | ||
| }) | ||
| } catch (e) { | ||
| console.error(e) | ||
| } |
There was a problem hiding this comment.
こういう二つの処理を同時にする時は、どっちか成功して片方失敗した時にデータに不整合おきるから、トランザクションで囲って、片方失敗した時は両方失敗になるような実装にしたい.
下の記事読んでないけど、firestoreのトランザクションで調べてみてほし
https://zenn.dev/yucatio/articles/7c4ba0d0138ca9
Comment on lines
+56
to
+62
| </Button> | ||
| <Button | ||
| colorScheme="alertRed" | ||
| size="md" | ||
| w={'5rem'} | ||
| h={'3rem'} | ||
| onClick={() => onClickDeleteUser(id)} |
There was a problem hiding this comment.
cssは、中括弧にシングルくォーテーションで統一したいclolorScheme={'alertRed'}みたいな
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💫 関連Issues
close #162
💪🏻 変更したこと
👀 確認項目