-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade packages to versions with Expo SDK support #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Looks like React Native 0.72 is not yet supported in Detox: I wrote some details about the Android test failure above here (this comment may need to be moved elsewhere, if it's not helpful in this issue): |
|
Maybe it's related to these exceptions: Importing this import com.facebook.react.views.slider.ReactSliderLooking at the changelog for 0.72, maybe this part is relevant: |
877efd1 to
2bc04c0
Compare
502623f to
e5ce0e2
Compare
e5ce0e2 to
9bede0b
Compare
5af6677 to
ea960c8
Compare
ea960c8 to
e3aac4d
Compare
e3aac4d to
2c1b828
Compare
2c1b828 to
a4b7026
Compare
a4b7026 to
6037796
Compare
6037796 to
90fa4c8
Compare
90fa4c8 to
bd2c940
Compare
6d87675 to
7c2a0bc
Compare
7c2a0bc to
a79770a
Compare
5b64f10 to
c013286
Compare
c013286 to
c116f18
Compare
afdfd0e to
d894e49
Compare
d894e49 to
091fb9c
Compare
091fb9c to
68012ed
Compare
68012ed to
b002cbf
Compare
1c7bc3d to
c2af4ec
Compare
d693e44 to
ce2cfc8
Compare
|
The iOS https://github.com/upleveled/hotline-bling-codealong/actions/runs/7673499851/job/20916233166?pr=164 Some people suggesting upgrading to |
8b1f901 to
7b07ce3
Compare
|
New Android failure after upgrading to |
|
Maybe Detox is also not compatible with React Native 0.73.x: |
The |
42f1466 to
ea0429f
Compare
a3d92cc to
87b9bab
Compare
c365efb to
74e9747
Compare
74e9747 to
69f3cde
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected] |
981e2fd to
96949c7
Compare
96949c7 to
71aab21
Compare
71aab21 to
16cb336
Compare
240622c to
1795362
Compare
1795362 to
6f84d2e
Compare
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|

Automated upgrade of packages to versions that are supported by current version of Expo SDK