S3 bucket config #39
Merged
S3 bucket config #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There’s a lot of trailing whitespace that my editor *insists* is cleaned up for linting. And will make it harder to see the _actual_ changes unless I do this first.
Allow us to specify the bucket and region for the s3 bucket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a developer to specify their own s3 bucket rather than the hardcoded one, and adds a missing empty "s3" dict in the config file.
There was a lot of whitespace cleaning up happening (due to linter), the easier to view diffs for what's actually changed are here: 1b9dc10
This is to fix issue #38 (Need an Amazon s3 bucket to login)