Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with slice + integer literals #5

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Fix bug with slice + integer literals #5

merged 4 commits into from
Jul 16, 2024

Conversation

tchajed
Copy link
Collaborator

@tchajed tchajed commented Jul 16, 2024

There's an ambiguity in [#(U64 1), #(U64 2)] between the vector notation (which starts with [#) and the list notation in expr_scope. This requires a space to resolve - even closing vector_scope isn't enough, because [# is still a single token.

tchajed and others added 4 commits July 16, 2024 13:26
@tchajed
Fix tests
a4b2471 
Disabled a couple things that aren't currently working (but aren't high
priority): array support is required for rfc1813, and the struct tests
include a complex expression that accesses a struct field by reference
from the result of a function call.
@tchajed
Fix some of the bats tests
ada6c5e
@tchajed
Fix parsing bug with slice + integer literals
e3167fd
@upamanyus
Fix bats tests
5acaeb2
@upamanyus upamanyus marked this pull request as ready for review July 16, 2024 19:32
@upamanyus upamanyus merged commit f7e8e90 into upamanyus:master Jul 16, 2024
1 check passed
@tchajed tchajed deleted the new/fix-slice-literal-bug branch July 16, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchajed @upamanyus