Fix the conditions under which achievements 13 and 20 are awarded. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the achievement required having fewer than 10 of each building, even though the description excluded Producers. Now it properly excludes Producers.
Previously, this achievement was awarded when boosting in under 60 seconds. Now it actually matches its description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these achievements were awarded under conditions that didn't match their descriptions. Achievement 13 "Nerd Boosters" required fewer than 10 of each building, even though the description excluded Producers. Achievement 20 "One and Only One" had the correct condition implemented, but there was also an extraneous line that awarded it when boosting in under 60 seconds
Both of these issues are resolved by this pull request.