catname on the IDS seems to sometimes be an array of strings #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnewhall
approved these changes
Apr 3, 2024
| return f.Val | ||
| } | ||
|
|
||
| func (f FlexString) Fake(faker *gofakeit.Faker) interface{} { |
There was a problem hiding this comment.
I need to read about what this does. hm
There was a problem hiding this comment.
powers the gofakeit stuff for running the integration tests in unpoller/unpoller
types.go
Outdated
|
|
||
| func (f FlexString) MarshalJSON() ([]byte, error) { | ||
| // array case | ||
| if f.Arr != nil && len(f.Arr) > 1 { |
There was a problem hiding this comment.
This will turn an array into a string if it only has 1 element. Seems fine for now, but something to keep in mind.
There was a problem hiding this comment.
alright added a hint here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A discord issue where on the IDS events the
catnamefield is now sometimes an array of stringsNow:
Before: