Skip to content

fix: Adjust check for https in RemoteControlClient #20405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@MartinZikmund MartinZikmund requested a review from dr1rrb May 15, 2025 07:41
@MartinZikmund
Copy link
Member Author

MartinZikmund commented May 15, 2025

@dr1rrb is this going to work correctly for Native WASM and Skia WASM? Not sure how to properly debug it

@MartinZikmund
Copy link
Member Author

@Mergifyio backport release/stable/6.0

Copy link
Contributor

mergify bot commented May 15, 2025

backport release/stable/6.0

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@MartinZikmund MartinZikmund enabled auto-merge May 15, 2025 07:42
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20405/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20405/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20405/wasm-skia-net9/index.html

@@ -21,6 +21,8 @@
<PackageId Condition="'$(UNO_UWP_BUILD)'=='false'">Uno.WinUI.DevServer</PackageId>

<UnoRuntimeIdentifier>Reference</UnoRuntimeIdentifier>

<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It can be a follow-up PR, but I think you can simply add this to Directory.Build.props and remove it from all csprojs in the whole repo.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 165756 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund disabled auto-merge May 15, 2025 12:17
@MartinZikmund MartinZikmund marked this pull request as draft May 15, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants