Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update internal absolute links #14924

Closed

Conversation

ajpinedam
Copy link
Contributor

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Documentation fixes

What is the current behavior?

Using absolute links makes it hard to test the documentation when using the staging builds. Also, using Markdown document linking ensures the documents are at the right location.

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam self-assigned this Dec 24, 2023
@ajpinedam ajpinedam changed the title docs: update internal absolute link (round 1) docs: update internal absolute links Dec 24, 2023
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14924/index.html

@ajpinedam ajpinedam marked this pull request as ready for review January 16, 2024 03:30
@ajpinedam ajpinedam force-pushed the docs/fix.internal.links branch from 4dead7d to 9246494 Compare February 16, 2024 05:28
doc/articles/interop/wasm-javascript-3.md Outdated Show resolved Hide resolved
doc/articles/uno-howto-create-a-repro.md Outdated Show resolved Hide resolved
doc/articles/uno-howto-create-a-repro.md Outdated Show resolved Hide resolved
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14924/index.html

@agneszitte
Copy link
Contributor

@jeromelaban I will let you review this PR as well

@@ -65,7 +65,7 @@ Microsoft MVP Skye Hoefling put together [Uno Platform: Getting Started Series](

### Raspberry Pi Applications with Uno Platform (Free)

If you are looking to bring your cross-platform apps to Raspberry Pi with Uno Platform, Peter Gallagher wrote an [article to help you get started]( https://www.petecodes.co.uk/developing-uwp-apps-for-the-raspberry-pi-with-uno-platform/) or try our [getting started with Raspberry Pi documentation]( https://platform.uno/docs/articles/guides/raspberry-pi/raspberry-pi-intro.html).
If you are looking to bring your cross-platform apps to Raspberry Pi with Uno Platform, Peter Gallagher wrote an [article to help you get started]( https://www.petecodes.co.uk/developing-uwp-apps-for-the-raspberry-pi-with-uno-platform/) or try our [getting started with Raspberry Pi documentation](/articles/guides/raspberry-pi/raspberry-pi-intro.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link doesn't work on staging. Maybe:

Suggested change
If you are looking to bring your cross-platform apps to Raspberry Pi with Uno Platform, Peter Gallagher wrote an [article to help you get started]( https://www.petecodes.co.uk/developing-uwp-apps-for-the-raspberry-pi-with-uno-platform/) or try our [getting started with Raspberry Pi documentation](/articles/guides/raspberry-pi/raspberry-pi-intro.md).
If you are looking to bring your cross-platform apps to Raspberry Pi with Uno Platform, Peter Gallagher wrote an [article to help you get started]( https://www.petecodes.co.uk/developing-uwp-apps-for-the-raspberry-pi-with-uno-platform/) or try our [getting started with Raspberry Pi documentation](./guides/raspberry-pi/raspberry-pi-intro.md).

This comment will apply to multiple changes in the PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajpinedam it's also best to use xref: links instead, wherever possible.

@jeromelaban jeromelaban marked this pull request as draft April 3, 2024 13:03
@morning4coffe-dev
Copy link
Member

Closing in favor of #17705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants