Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: MediaPlayerElement shouldn't be IDisposable #12274

Merged
merged 1 commit into from
May 13, 2023
Merged

fix!: MediaPlayerElement shouldn't be IDisposable #12274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/Uno.UI/UI/Xaml/Controls/MediaPlayerElement/MediaPlayerElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ namespace Windows.UI.Xaml.Controls
[TemplatePart(Name = MediaPlayerPresenterName, Type = typeof(MediaPlayerPresenter))]
[TemplatePart(Name = LayoutRootName, Type = typeof(Grid))]
public partial class MediaPlayerElement
#if __IOS__ || __ANDROID__ || __MACOS__
// To avoid causing FrameworkElement.Dispose to become virtual (and cause a breaking change),
// we keep the disposable for existing platforms, but we don't implement it for the other targets.
: IDisposable
#endif
{
private const string PosterImageName = "PosterImage";
private const string TransportControlsPresenterName = "TransportControlsPresenter";
Expand Down