Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove OnWindowCreated from WinUI tree #12196

Closed

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented May 8, 2023

BREAKING CHANGE: Application.OnWindowCreated does not exist in WinAppSDK

GitHub Issue (If applicable): part of #8339

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@MartinZikmund MartinZikmund self-assigned this May 10, 2023
@MartinZikmund MartinZikmund force-pushed the dev/mazi/remove-onwindowcreated branch from bb368b8 to 7a633b0 Compare May 10, 2023 11:58
BREAKING CHANGE: Application.OnWindowCreated does not exist in WinAppSDK
@MartinZikmund MartinZikmund force-pushed the dev/mazi/remove-onwindowcreated branch from 7a633b0 to 4f2f036 Compare June 5, 2023 12:07
@MartinZikmund MartinZikmund changed the title [WIP] fix!: Remove OnWindowCreated from WinUI tree fix!: Remove OnWindowCreated from WinUI tree Jun 5, 2023
@MartinZikmund MartinZikmund requested a review from Youssef1313 June 5, 2023 12:08
@MartinZikmund MartinZikmund marked this pull request as ready for review June 5, 2023 12:08
@jeromelaban jeromelaban deleted the branch feature/breaking-changes June 9, 2023 17:39
@jeromelaban jeromelaban closed this Jun 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

⚠️ The sha of the head commit of this PR conflicts with #12594. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants