Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Align WebView.NavigateWithHttpRequestMessage signature with UWP #11344

Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Feb 16, 2023

BREAKING CHANGE: WebView.NavigateWithHttpRequestMessage parameter type is now Windows.Web.Http.HttpRequestMessage instead of System.Net.Http.HttpRequestMessage

GitHub Issue (If applicable): #8339, closes #11099

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform labels Feb 16, 2023
@Youssef1313
Copy link
Member Author

@MartinZikmund FYI

@Youssef1313 Youssef1313 linked an issue Feb 16, 2023 that may be closed by this pull request
@Youssef1313 Youssef1313 force-pushed the webview-align branch 2 times, most recently from f9150f5 to 0aa65a4 Compare February 16, 2023 19:17
BREAKING CHANGE: WebView.NavigateWithHttpRequestMessage parameter type is now `Windows.Web.Http.HttpRequestMessage` instead of `System.Net.Http.HttpRequestMessage`
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Feb 17, 2023
@Youssef1313 Youssef1313 merged commit a097b3d into unoplatform:feature/breaking-changes Feb 17, 2023
@Youssef1313 Youssef1313 deleted the webview-align branch February 21, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebView.NavigateWithHttpRequestMessage has wrong parameter type
2 participants