fix!: Make SolidColorBrushHelper internal
#11168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/code-generation
jeromelaban
reviewed
Feb 2, 2023
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
Show resolved
Hide resolved
|
@jeromelaban Is this ready to merge? |
|
Let's wait until we rebase the feature/breaking-changes branch. After that I'll update PackageDiffIgnore so we can get it merged. |
BREAKING CHANGE: `SolidColorBrushHelper` isn't available in UWP, so we are making it internal.
Youssef1313
force-pushed
the
solidcolorbrushhelper
branch
from
66537ba to
fe6e53a
Compare
github-actions
bot
added
the
area/build
Youssef1313
commented
Feb 15, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jeromelaban
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
SolidColorBrushHelperisn't available in UWP, so we are making it internal.GitHub Issue (If applicable): Closes #11127, Part of #8339
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):