Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Make ContentPropertyAttribute.Name field instead of a property. #11164

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Feb 2, 2023

BREAKING CHANGE: ContentPropertyAttribute.Name is now a field to match UWP.

GitHub Issue (If applicable): Part of #8339, closes #10841

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

BREAKING CHANGE: `ContentPropertyAttribute.Name` is now a field to match UWP.
@Youssef1313 Youssef1313 changed the base branch from master to feature/breaking-changes February 2, 2023 13:12
@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label Feb 2, 2023
@jeromelaban jeromelaban marked this pull request as draft February 3, 2023 13:32
@Youssef1313 Youssef1313 marked this pull request as ready for review February 8, 2023 05:43
@Youssef1313
Copy link
Member Author

@jeromelaban Is this ready to merge?

@jeromelaban jeromelaban merged commit f6c0d72 into unoplatform:feature/breaking-changes Feb 15, 2023
@Youssef1313 Youssef1313 deleted the contentproperty-name branch February 15, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContentPropertyAttribute.Name should be a field, not a property, to match Windows
3 participants