Merge pull request #18085 from Youssef1313/init-only

fix: Consider init-only properties as not settable in bindable type generator
unoplatform · Aug 31, 2024 · 0a56fe8 · 0a56fe8
2 parents 8122799 + 46e75e2
commit 0a56fe8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...tors/Uno.UI.SourceGenerators/BindableTypeProviders/BindableTypeProvidersGenerationTask.cs b/...tors/Uno.UI.SourceGenerators/BindableTypeProviders/BindableTypeProvidersGenerationTask.cs
@@ -364,7 +364,7 @@ where field.IsStatic
 
 							if (
 								property.SetMethod != null
-								&& property.SetMethod != null
+								&& !property.SetMethod.IsInitOnly
 								&& property.SetMethod.IsLocallyPublic(_currentModule!)
 								)
 							{

diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Data/BindableNullableValueTypeTestPage.xaml.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Data/BindableNullableValueTypeTestPage.xaml.cs
@@ -30,4 +30,8 @@ public int? MyProperty
 			}
 		}
 	}
+
+#if !WINAPPSDK // https://github.com/microsoft/microsoft-ui-xaml/issues/5315
+	public int MyInitOnlyProperty { get; init; }
+#endif
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,4 +30,8 @@ public int? MyProperty @@
     			}
     		}
     	}
+    #if !WINAPPSDK // https://github.com/microsoft/microsoft-ui-xaml/issues/5315
+    	public int MyInitOnlyProperty { get; init; }
+    #endif
     }