Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CommandExtensions): parameter resolution & add support for Selector (backport #1170) #1176

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 29, 2024

GitHub Issue (If applicable): n/a

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • CommandExtensions.Command is not supported on Selector (except ListView)
  • CommandExtensions.CommandParameter resolution for NavigationView and Selector doesnt work on their item-container or item-template's root

What is the new behavior?

  • Command now works on Selector
  • CommandParameter now correctly resolves from item-container or item-template's root of NavigationView and Selector (barring ListView)

PR Checklist

Please check if your PR fulfills the following requirements:

Other information


This is an automatic backport of pull request #1170 done by [Mergify](https://mergify.com).

Co-authored-by: Steve Bilogan <[email protected]>
(cherry picked from commit 7ae511c)
@Xiaoy312 Xiaoy312 merged commit 2c8ab86 into release/stable/6.1 Jul 2, 2024
24 checks passed
@Xiaoy312 Xiaoy312 deleted the mergify/bp/release/stable/6.1/pr-1170 branch July 2, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant