Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CommandExtensions warning on Text/PasswordBox #1168

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Jun 26, 2024

GitHub Issue (If applicable): n/a

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

non-sense warning being logged erroneously:

Uno.Toolkit.UI.CommandExtensions: Warning: CommandExtensions.Command is not supported on 'Microsoft.UI.Xaml.Controls.PasswordBox'.

What is the new behavior?

^ no more.

PR Checklist

Please check if your PR fulfills the following requirements:

@Xiaoy312 Xiaoy312 enabled auto-merge June 26, 2024 17:34
Copy link
Contributor Author

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@Xiaoy312 Xiaoy312 requested a review from kazo0 June 26, 2024 17:36
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1168.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit ba41d78 into main Jun 26, 2024
25 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20240626/txt-pw-box-command-warning branch June 26, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants