generated from unoplatform/template
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drawer): DrawerControl.IsOpen exceptions #1156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixme: use dipatchercompat |
kazo0
approved these changes
Jun 12, 2024
Xiaoy312
force-pushed
the
dev/xygu/20240610/drawer-isopen-throws
branch
2 times, most recently
from
June 13, 2024 16:07
45ba0d2
to
de609d6
Compare
dr1rrb
reviewed
Jun 13, 2024
dr1rrb
reviewed
Jun 13, 2024
Xiaoy312
force-pushed
the
dev/xygu/20240610/drawer-isopen-throws
branch
from
June 14, 2024 00:20
de609d6
to
047bcc3
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1156.eastus2.azurestaticapps.net |
Xiaoy312
force-pushed
the
dev/xygu/20240610/drawer-isopen-throws
branch
from
June 14, 2024 00:39
047bcc3
to
8bdb0ae
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1156.eastus2.azurestaticapps.net |
agneszitte
approved these changes
Jun 17, 2024
ios uwp ci kept failing... |
@Xiaoy312 it's fine :) Merge when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #1162
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
fixed a couple exceptions related to DrawerControl.IsOpen
PR Checklist
Please check if your PR fulfills the following requirements: