Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): DrawerControl.IsOpen exceptions #1156

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Jun 10, 2024

GitHub Issue (If applicable): closes #1162

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

fixed a couple exceptions related to DrawerControl.IsOpen

PR Checklist

Please check if your PR fulfills the following requirements:

@Xiaoy312
Copy link
Contributor Author

fixme: use dipatchercompat

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240610/drawer-isopen-throws branch 2 times, most recently from 45ba0d2 to de609d6 Compare June 13, 2024 16:07
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240610/drawer-isopen-throws branch from de609d6 to 047bcc3 Compare June 14, 2024 00:20
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1156.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240610/drawer-isopen-throws branch from 047bcc3 to 8bdb0ae Compare June 14, 2024 00:39
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1156.eastus2.azurestaticapps.net

@Xiaoy312
Copy link
Contributor Author

ios uwp ci kept failing...
20240618 re-queued again

@jeromelaban
Copy link
Member

@Xiaoy312 it's fine :) Merge when ready

@Xiaoy312 Xiaoy312 merged commit f24aff9 into main Jun 19, 2024
25 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20240610/drawer-isopen-throws branch June 19, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants