fix: Navigate once when starting app with same route as navigated #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazo0
reviewed
Dec 9, 2024
eriklimakc
force-pushed
the
dev/erli/deeplinking-navigation
branch
from
7310dd5 to
ae9c07f
Compare
eriklimakc
changed the title
kazo0
reviewed
Dec 11, 2024
eriklimakc
force-pushed
the
dev/erli/deeplinking-navigation
branch
from
52bbc83 to
5d63323
Compare
eriklimakc
commented
Dec 12, 2024
testing/TestHarness/TestHarness/Ext/Navigation/AddressBar/AddressBarHomePage.xaml
Outdated
Show resolved
Hide resolved
kazo0
approved these changes
Jan 13, 2025
|
@Mergifyio backport release/stable/5.2 |
✅ Backports have been created
|
7 tasks
kazo0
added a commit
that referenced
this pull request
Jan 13, 2025
….2/pr-2639 fix: Navigate once when starting app with same route as navigated (backport #2639)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #2607
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When specifying a route on the addressbar (e.g., https://url/Main) the first navigation is triggered in two ways. This behavior can be observed on lines 36 and 44 in the following file: FrameworkElementExtensions.cs. This way the
initialNavigationnavigates to""which eventually navigates to "Main" because it's the default route andstartnavigates to "Main" because it was the route specified, causing a double navigation.What is the new behavior?
We check if the route navigated to is the same to the one provided via addressbar, if so we don't navigate.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.