Add SocketCAN functionality #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings SocketCAN from upstream back to origin with already existing changes from main for workflows and other changes.
Some of the functions and implementations were not readily available nor created. This now resolves those issues.
This commit adds the implementation for the SocketCANDevice class, which was previously missing some functions and implementations. Now all required functions are available and the issues have been resolved.
This was missing the previous commit. Change compiler options to have SocketCANThread actually compile instead of not.
Mirroring SerialDeviceThread.h as it was changed years ago.
Adding more compiler args to prevent other platforms that are not able to compile some platforms to compile files, as it would just error and fail the build. Fixing broken functions such as `SocketCANDevice::GetID()` as it was not returning a string. This is now not implemented but it returns an `int` which is correct for the function.
Fix SocketCANDevice from being broken on compiles, from broken constructors to missing includes.
This is largely untested, however this should bring the functionality of the SocketCAN work somewhat back into play.
This tears out the majority of what was [candle_dll](https://github.com/HubertD/candle_dll/tree/master) for the Linux driver and implemented the Linux [SocketCAN](https://docs.kernel.org/networking/can.html) driver. Preliminary testing shows that this does functionally work with a single SPARK MAX motor controller, however further testing may be required.
Updated section for Linux support.
NoahAndrews
suggested changes
Aug 22, 2024
Plans to fully delete the serial driver are underway, as this is not supported or even functioning with current firmware.
garrettsummerfi3ld
added a commit
to unofficial-rev-port/node-can-bridge
that referenced
this pull request
Aug 30, 2024
SocketCAN support is dependent on merging unofficial-rev-port/CANBridge#5.
SocketCAN devices aren't exclusively, changing it to something more generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Linux SocketCAN driver into CANBridge.
This is based off of the
REVrobotics/CANBridgeSocketCAN branch with lots of updates to compiling, driver code, and rewriting SocketCAN related code already existing to utilize the Linux kernel drivers.