Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Recoverable keys feature for the dashboard #2110
base: main
Are you sure you want to change the base?
feat: Recoverable keys feature for the dashboard #2110
Changes from 14 commits
75db25a
365117e
ab6ad58
197fe6e
b795941
e1a92c2
3379c0e
7cd8dc6
6f903de
43aa747
e89dfa3
c8d08d0
babbde4
4b74619
596b315
7ffdbc4
7028fc4
2d6d304
68c6599
ee40896
ca22641
2bcfb89
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't resolve the issue of key inserts even if the encryption fails.
You need to handle rollback of the key creation if the encryption fails. You either need to wrap the transaction in the create transaction, or you need to handle the rollback manually. Otherwise an end user will have extra keys for no reasons.
It should be something like:
Happy path:
Unsuccessful:
Some reading.
https://orm.drizzle.team/docs/transactions#transactions