test: improve accuracy of lower limit calculation in rate limit tests

unkeyed · Sep 19, 2024 · 5036426 · 5036426
1 parent a43b948
commit 5036426
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apps/api/src/routes/v1_keys_verifyKey.ratelimit_accuracy.test.ts b/apps/api/src/routes/v1_keys_verifyKey.ratelimit_accuracy.test.ts
@@ -94,7 +94,7 @@ for (const { limit, duration, rps, seconds } of testCases) {
 
     const exactLimit = Math.min(results.length, (limit / (duration / 1000)) * seconds);
     const upperLimit = Math.round(exactLimit * 2.5);
-    const lowerLimit = exactLimit * 0.95;
+    const lowerLimit = Math.round(exactLimit * 0.95);
     console.info({ name, passed, exactLimit, upperLimit, lowerLimit });
     t.expect(passed).toBeGreaterThanOrEqual(lowerLimit);
     t.expect(passed).toBeLessThanOrEqual(upperLimit);

diff --git a/apps/api/src/routes/v1_ratelimit_limit.accuracy.test.ts b/apps/api/src/routes/v1_ratelimit_limit.accuracy.test.ts
@@ -97,7 +97,7 @@ for (const { limit, duration, rps, seconds } of testCases) {
 
     const exactLimit = Math.min(results.length, (limit / (duration / 1000)) * seconds);
     const upperLimit = Math.round(exactLimit * 1.5);
-    const lowerLimit = exactLimit * 0.95;
+    const lowerLimit = Math.round(exactLimit * 0.95);
     console.info({ name, passed, exactLimit, upperLimit, lowerLimit });
     t.expect(passed).toBeGreaterThanOrEqual(lowerLimit);
     t.expect(passed).toBeLessThanOrEqual(upperLimit);