-
Notifications
You must be signed in to change notification settings - Fork 170
feat(drivers): enhance drivers with typed options for get, set, remove, and list operations via generation
#662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
schplitt
wants to merge
20
commits into
unjs:main
Choose a base branch
from
schplitt:feat/typed-driver-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+357
−33
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4bd936d
feat(drivers): enhance drivers with typed options for get, set, remov…
schplitt 54244e3
fix: lint
schplitt 5ace236
fix: correct get and set options
schplitt 561aee7
feat(types): implement WithSafeName utility type
schplitt c6df26a
fix: lint
schplitt b094800
feat(types): implement SafeName utility type and refactor getSafeName…
schplitt c9e65ed
chore: apply automated updates
autofix-ci[bot] ed3bff9
refactor(utils): move getSafeName function to gen-drivers
schplitt 79f7c7b
chore: apply automated updates
autofix-ci[bot] 5a5b77a
refactor(types): use only driver name casing for driver options
schplitt 0778cfb
refactor: use generated `GetOptions` inside deno driver
schplitt 60ba7d7
docs: add guide for creating drivers with typed options
schplitt ef7636a
chore: apply automated updates
autofix-ci[bot] 995a569
chore: apply automated updates (attempt 2/3)
autofix-ci[bot] a8ba05f
docs: better structure
schplitt 39455f3
refactor(types): rename driver options to use safe names and add clea…
schplitt 9558f33
docs: add contributing guide for developing drivers in Unstorage
schplitt 05a9600
docs: add clear options
schplitt 4cf481f
docs: add general contribution guide
schplitt 46293c6
chore: apply automated updates
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,182 @@ | ||
| # Contribution Guide | ||
|
|
||
| <!-- https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors --> | ||
|
|
||
| > All contributors lead the growth of Unstorage - including you! | ||
|
|
||
| ## Discussions | ||
|
|
||
| You can involve in discussions using: | ||
|
|
||
| - [GitHub Discussions](https://github.com/unjs/unstorage/discussions) | ||
|
|
||
| ## Contribute to the Code | ||
|
|
||
| > [!IMPORTANT] | ||
| > Please discuss your ideas with the maintainers before opening a pull request. | ||
|
|
||
| ### Local Development | ||
|
|
||
| - Clone the [`unjs/unstorage`](https://github.com/unjs/unstorage) git repository. | ||
| - Install the latest LTS version of [Node.js](https://nodejs.org/en/) (v22+). | ||
| - Enable [corepack](https://github.com/nodejs/corepack) using `corepack enable` (run `npm i -g corepack` if it's not available). | ||
| - Install dependencies using `pnpm install`. | ||
| - Run the generation script after creating a new driver using `pnpm generate`. | ||
| - Build the project using `pnpm build`. | ||
| - Add, modify, and run tests using `pnpm test`. | ||
|
|
||
| ## Reporting Issues | ||
|
|
||
| You might encounter a bug while using Unstorage. | ||
|
|
||
| Although we aim to resolve all known issues, new bugs can emerge over time. Your bug report helps us find and fix them faster — even if you're unable to fix the underlying code yourself. | ||
|
|
||
| Here’s how to report a bug effectively: | ||
|
|
||
| ### Ensure It's a Bug | ||
|
|
||
| Sometimes what seems like a bug may actually be expected behavior or a missing feature. Make sure you’re reporting an actual bug by creating a minimal unstorage project and reducing scope. | ||
|
|
||
| ### Create a Minimal Reproduction | ||
|
|
||
| Please create a minimal reproduction using the starter templates or a simple repository. | ||
|
|
||
| Sometimes, bugs originate from another layer — not Unstorage itself. A minimal reproduction helps identify the source and speeds up debugging. | ||
|
|
||
| If your bug involves a higher-level framework, please report it there. Maintainers will help narrow it down to an Unstorage-level issue if needed. | ||
|
|
||
| ### Search Existing Issues and Discussions | ||
|
|
||
| Before creating a new issue, search existing [issues](https://github.com/unjs/unstorage/issues) and [discussions](https://github.com/unjs/unstorage/discussions) to see if your bug has already been reported. | ||
|
|
||
| If it has already been reported: | ||
|
|
||
| - Add a 👍 reaction to the original post (instead of commenting "me too" or "when will it be fixed"). | ||
| - If you can provide additional context or a better/smaller reproduction, please share it. | ||
|
|
||
| > [!NOTE] | ||
| > If the issue seems related but different or old or already closed, it's **better to open a new issue**. Maintainers will merge similar issues if needed. | ||
|
|
||
| ## Contributing: Developing Drivers for Unstorage | ||
|
|
||
| This guide explains how to develop a custom driver for `unstorage`, including naming conventions, typing options, and best practices. For a practical example, see the [`deno-kv` driver](https://github.com/unjs/unstorage/blob/main/src/drivers/deno-kv.ts). | ||
|
|
||
| ## 1. Naming Your Driver and Options | ||
|
|
||
| - **Driver file:** Use a clear, kebab-case name (e.g., `my-custom-driver.ts`). | ||
| - **Options interface:** Name it as `MyCustomOptions` (PascalCase, ends with `Options`). | ||
| - **Driver interface:** Name it as `MyCustomDriver` (PascalCase, ends with `Driver`). | ||
| - **Driver name constant:** It is recommended to use a `DRIVER_NAME` constant as the driver name in the implementation and should match the pattern in [`src/drivers`](https://github.com/unjs/unstorage/tree/main/src/drivers) (see e.g. `deno-kv.ts`, `fs.ts`, `redis.ts`). The file name should match the `DRIVER_NAME` constant. | ||
| - **File name transformation:** The file name is used to determine how to access the driver's options in the global options types. Internally, a transformation (is applied to the file name for type access. For example, `deno-kv` becomes `denoKV`, so you would access options as `opts.denoKV`. | ||
|
|
||
| ## 2. Typing Driver Options | ||
|
|
||
| Define an options interface for your driver. This describes the configuration users can pass when initializing the driver. | ||
|
|
||
| ```ts | ||
| // my-custom-driver.ts | ||
| export interface MyCustomOptions { | ||
| path: string; | ||
| ttl?: number; | ||
| } | ||
| ``` | ||
|
|
||
| ## 3. Typing Driver Methods | ||
|
|
||
| Define a driver interface with the suffix `Driver`. This interface should have the following properties: | ||
|
|
||
| - `getOptions`: Type for options passed to `getItem`. | ||
| - `setOptions`: Type for options passed to `setItem`. | ||
| - `removeOptions`: Type for options passed to `removeItem`. | ||
| - `listOptions`: Type for options passed to `getKeys`. | ||
| - `clearOptions`: Type for options passed to `clear` (if your driver supports it). | ||
|
|
||
| Example: | ||
|
|
||
| ```ts | ||
| export interface MyCustomDriver { | ||
| getOptions: { raw?: boolean }; | ||
| setOptions: { foo?: string }; | ||
| removeOptions: {}; | ||
| listOptions: { prefix?: string }; | ||
| clearOptions: { deep?: boolean }; | ||
| } | ||
| ``` | ||
|
|
||
| ## 4. Implementing the Driver | ||
|
|
||
| Use the `defineDriver` helper, passing your options and driver types: | ||
|
|
||
| ```ts | ||
| import { defineDriver } from "unstorage"; | ||
| import type { MyCustomOptions, MyCustomDriver } from "./my-custom-driver"; | ||
| import type { | ||
| GetOptions, | ||
| SetOptions, | ||
| RemoveOptions, | ||
| ListOptions, | ||
| ClearOptions, | ||
| } from "../types"; | ||
|
|
||
| const DRIVER_NAME = "my-custom-driver"; | ||
|
|
||
| export default defineDriver<MyCustomOptions, unknown, MyCustomDriver>( | ||
| (options) => { | ||
| return { | ||
| name: DRIVER_NAME, | ||
| async getItem(key, opts: GetOptions) { | ||
| // Get the raw option | ||
| const raw = opts?.["my-custom-driver"]?.raw; | ||
| /** Implementation */ | ||
| }, | ||
| async setItem(key, value, opts: SetOptions) { | ||
| /** Implementation */ | ||
| }, | ||
| async removeItem(key, opts: RemoveOptions) { | ||
| /** Implementation */ | ||
| }, | ||
| async getKeys(base, opts: ListOptions) { | ||
| /** Implementation */ | ||
| }, | ||
| async clear(base, opts: ClearOptions) { | ||
| /** Implementation */ | ||
| }, | ||
| // ...other methods... | ||
| }; | ||
| } | ||
| ); | ||
| ``` | ||
|
|
||
| Take a look at the [deno driver](https://github.com/unjs/unstorage/blob/main/src/drivers/deno-kv.ts) for a complete implementation example with typed options. | ||
|
|
||
| ## 5. Generating and Using Types Globally | ||
|
|
||
| After defining your driver and its types: | ||
|
|
||
| 1. **Run the code generation script:** | ||
|
|
||
| ```sh | ||
| pnpm gen-drivers | ||
| ``` | ||
|
|
||
| This will update the generated types so your driver's options are available inside the `GetOptions`, `SetOptions`, `RemoveOptions`, and `ListOptions` types. | ||
|
|
||
| 2. **Use the generated types** in your code: | ||
|
|
||
| ```ts | ||
| import type { SetOptions } from "unstorage"; | ||
|
|
||
| defineDriver((options) => { | ||
| return { | ||
| async setItem(key, value, opts: SetOptions) { | ||
| // opts is typed for your driver | ||
| }, | ||
| }; | ||
| }); | ||
| ``` | ||
|
|
||
| Some important notes: | ||
|
|
||
| - Always use the `Driver` and `Options` suffixes for your types. | ||
| - Document your options and method behaviors. | ||
| - Document if your driver supports the [common options](https://github.com/unjs/unstorage/blob/src/types.ts#L27) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.