Skip to content

Conversation

@ToBinio
Copy link
Contributor

@ToBinio ToBinio commented Jul 9, 2025

resolves #336

This makes clear delete all keys starting with base - #336 (comment)

this PR also includes various other fixes which I discovered while implementing

sry for the big amount of commits - while implementing, I once deleted the whole project folder with the fs drivers and lost all my progress...

unable to test:

azure-cosmos
azure-key-vault
azure-app-configuration

planetscale

vercel-kv - does no longer seem to be a thing

Important

storage expects drivers to correctly implement clear() and calls clear() on mounts that only partialy contain data which is supposed to be deleted - meaning if clear does not respect base unexpected deletions can happen!
please test carefully

@ToBinio ToBinio requested a review from pi0 as a code owner July 9, 2025 19:39
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 65.28926% with 42 lines in your changes missing coverage. Please review.

Project coverage is 61.45%. Comparing base (70310f9) to head (c016043).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/drivers/azure-storage-table.ts 9.09% 10 Missing ⚠️
src/drivers/azure-key-vault.ts 10.00% 9 Missing ⚠️
src/drivers/azure-storage-blob.ts 11.11% 8 Missing ⚠️
src/drivers/planetscale.ts 0.00% 5 Missing ⚠️
src/drivers/cloudflare-kv-http.ts 0.00% 3 Missing ⚠️
src/drivers/uploadthing.ts 40.00% 3 Missing ⚠️
src/drivers/azure-app-configuration.ts 50.00% 1 Missing ⚠️
src/drivers/azure-cosmos.ts 50.00% 1 Missing ⚠️
src/drivers/utils/node-fs.ts 80.00% 1 Missing ⚠️
src/drivers/vercel-blob.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   59.99%   61.45%   +1.46%     
==========================================
  Files          42       42              
  Lines        3657     3840     +183     
  Branches      590      650      +60     
==========================================
+ Hits         2194     2360     +166     
- Misses       1460     1477      +17     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistency between clear and getKeys

1 participant