types: omit declaration in the entries for "rollup" and "copy" builders
#530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kricsleo
changed the title
declaration from builders that do not support itdeclaration in the entries for "rollup" and "copy" builders
pi0
changed the title
declaration in the entries for "rollup" and "copy" buildersdeclaration in the entries for "rollup" and "copy" builders
pi0
reviewed
Apr 14, 2025
| options.declaration !== undefined && | ||
| entry.declaration === undefined | ||
| ) { | ||
| entry.declaration = !!options.declaration; |
There was a problem hiding this comment.
Let's keep runtime simple. it is simply an additional feature used by mkdist
There was a problem hiding this comment.
keep runtime simple.
Otherwise, we’d need @ts-expect-error to suppress type errors...
used by mkdist
Not just mkdist, untyped also uses it: https://github.com/unjs/unbuild/blob/main/src/builders/untyped/index.ts#L70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #529